It's not as simple as where they "live" or where they own homes. Taxation of professional athletes is an
extremely complex issue. Not only do they potentially owe income taxes in their state of domicile (i.e., state of permanent residence), but they also potentially owe income taxes in every state in which they (a) have a residence, and (b) play a game. For example, in 2012, the Kings played three games in the State of New Jersey and probably spent about 8-10 days in NJ in advance of and between those games. As a result, the Kings players will owe NJ state income taxes based on their earnings attributable to those games.
I don't pretend to know all the ins and outs of this, but this article does a pretty good job of highlighting the issues:
Hodgson Russ LLP - The Multistate Tax Quandary for Professional Athletes
This is true of the players who play and live in non-income tax states as well, so it doesn't negate the impact of state taxes. To suggest that "good tax dude[s]" and charitable work can make up for high state taxes is naive in the extreme; it is a very real issue.
I think the impact of state taxes on a team's ability to sign players is fairly minimal. The top players do not disproportionately congregate to teams in Texas and Florida. In fact, it could be argued that they disproportionately congregate to teams in high income tax states like California, New York, New Jersey, and Massachusetts, whose teams have won 12 World Series, 7 Stanley Cups, 9 Super Bowls, and 7 NBA Championships over the past 25 years (by contrast, teams in Texas and Florida have won a total of 10 titles over the same period).
Jerry Lewis and Redd Foxx??? Not exactly current, and don't/didn't they live in Vegas because that's where they performed a majority of their work? Huge numbers of high earners in the entertainment industry live in high income tax states like California and New York.